Skip to content

feat: components v2 in builders #10788

Merged
kodiakhq[bot] merged 37 commits intomainfrom
feat/components-v2
Apr 23, 2025
Merged

feat: components v2 in builders #10788
kodiakhq[bot] merged 37 commits intomainfrom
feat/components-v2

Conversation

@vladfrangu
Copy link
Copy Markdown
Member

@vladfrangu vladfrangu commented Mar 3, 2025

Please describe the changes this PR makes and why it should be merged:

🤫

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed) [tbd]

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 3:52pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2025 3:52pm

didinele
didinele requested changes Mar 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't look at your tests; otherwise, so far mostly LGTM

Comment thread packages/builders/src/components/v2/Section.ts Outdated
Comment thread packages/builders/src/components/v2/MediaGalleryItem.ts Outdated
@github-project-automation github-project-automation Bot moved this from Todo to Review in Progress in discord.js Mar 3, 2025
Qjuh
Qjuh requested changes Mar 3, 2025
View reviewed changes
Comment thread packages/builders/src/components/v2/Section.ts Outdated
Comment thread packages/builders/src/components/v2/Section.ts
Comment thread packages/builders/src/components/v2/MediaGallery.ts
Comment thread packages/builders/src/components/v2/MediaGallery.ts
Comment thread packages/builders/src/components/v2/MediaGallery.ts Outdated
Comment thread packages/builders/src/components/v2/Section.ts
Comment thread packages/builders/src/components/v2/Separator.ts
Comment thread packages/builders/src/components/v2/TextDisplay.ts
Comment thread packages/builders/src/components/v2/Thumbnail.ts
Comment thread packages/builders/src/components/v2/Separator.ts
@vladfrangu vladfrangu marked this pull request as ready for review March 4, 2025 12:37
@vladfrangu vladfrangu requested review from a team as code owners March 4, 2025 12:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.00000% with 91 lines in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (42ce116) to head (1f7ba47).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/builders/src/messages/Message.ts 25.39% 47 Missing ⚠️
packages/builders/src/components/v2/Section.ts 69.52% 32 Missing ⚠️
packages/builders/src/components/Components.ts 68.75% 10 Missing ⚠️
...ackages/builders/src/components/v2/MediaGallery.ts 95.74% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main   #10788       +/-   ##
===========================================
+ Coverage   42.66%   71.93%   +29.27%     
===========================================
  Files         251      145      -106     
  Lines       14749     8531     -6218     
  Branches     1458     1434       -24     
===========================================
- Hits         6292     6137      -155     
+ Misses       8445     2382     -6063     
  Partials       12       12
Flag Coverage Δ
brokers 31.41% <ø> (ø)
builders 80.07% <86.00%> (+2.21%) ⬆️
collection 100.00% <ø> (ø)
discord.js ?
guide ?
next ?
util 43.28% <ø> (ø)
utilities 100.00% <ø> (ø)
website ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Qjuh
Qjuh previously requested changes Mar 4, 2025
View reviewed changes
Comment thread packages/builders/src/components/selectMenu/BaseSelectMenu.ts Outdated
Comment thread packages/builders/src/components/v2/Assertions.ts
Comment thread packages/builders/src/components/v2/Container.ts
didinele
didinele requested changes Mar 5, 2025
View reviewed changes
Comment thread packages/builders/src/components/Component.ts Outdated
Comment thread packages/builders/src/components/selectMenu/StringSelectMenuOption.ts Outdated
Comment thread packages/builders/src/components/v2/Assertions.ts
Comment thread packages/builders/src/components/v2/Assertions.ts
Comment thread packages/builders/src/components/v2/Separator.ts Outdated
Comment thread packages/builders/src/interactions/modals/Modal.ts Outdated
Comment thread packages/builders/src/messages/embed/Embed.ts Outdated
Comment thread packages/builders/src/messages/embed/EmbedAuthor.ts Outdated
Comment thread packages/builders/src/messages/embed/EmbedField.ts Outdated
Comment thread packages/builders/src/messages/embed/EmbedFooter.ts Outdated
@vladfrangu vladfrangu force-pushed the feat/components-v2 branch from 73107a2 to 62124db Compare March 5, 2025 14:45
@vladfrangu vladfrangu requested review from Qjuh and didinele March 14, 2025 08:27
Qjuh
Qjuh requested changes Mar 14, 2025
View reviewed changes
Comment thread packages/builders/src/components/v2/Container.ts Outdated
Comment thread packages/builders/src/components/v2/Container.ts Outdated
Comment thread packages/builders/src/messages/Assertions.ts Outdated
Comment thread packages/builders/src/messages/Assertions.ts Outdated
Comment thread packages/builders/src/messages/Assertions.ts Outdated
Comment thread packages/builders/src/messages/Message.ts Outdated
Comment thread packages/builders/src/messages/Message.ts Outdated
Comment thread packages/builders/src/messages/Message.ts Outdated
vladfrangu and others added 16 commits April 23, 2025 01:34
@vladfrangu vladfrangu requested a review from Qjuh April 23, 2025 10:45
didinele
didinele requested changes Apr 23, 2025
View reviewed changes
Comment thread packages/builders/src/components/v2/MediaGallery.ts Outdated
Comment thread packages/builders/src/components/v2/Container.ts Outdated
Comment thread packages/builders/src/components/v2/Section.ts Outdated
@vladfrangu @didinele
Apply suggestions from code review
9291c6b 
Co-authored-by: Denis-Adrian Cristea <didinele.dev@gmail.com>
@Jiralite Jiralite added this to the builders 2.0.0 milestone Apr 23, 2025
@github-project-automation github-project-automation Bot moved this from Review in Progress to Review Approved in discord.js Apr 23, 2025
@kodiakhq kodiakhq Bot merged commit abc5d99 into main Apr 23, 2025
24 checks passed
@kodiakhq kodiakhq Bot deleted the feat/components-v2 branch April 23, 2025 17:29
@github-project-automation github-project-automation Bot moved this from Review Approved to Done in discord.js Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didinele didinele didinele approved these changes

@Jiralite Jiralite Jiralite approved these changes

@Qjuh Qjuh Qjuh approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/builders

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/builders

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC was automatically assigned from discordjs/core

Assignees

No one assigned

Labels

api support backport-candidate packages:builders semver:minor

Projects

discord.js
Archived in project

Milestone

builders 2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@vladfrangu @didinele @Jiralite @Qjuh